Re: pgsql: Clean up role created in new subscription test.

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Clean up role created in new subscription test.
Date: 2023-11-08 07:55:32
Message-ID: 41dba437-5622-4ae0-a6bb-726da8771584@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 06.07.23 00:00, Daniel Gustafsson wrote:
>> On 16 May 2023, at 11:17, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
>> Parked in the July CF for now.
>
> Rebased to fix a trivial conflict highlighted by the CFBot.

I think the problem with this approach is that one would need to reapply
it to each regression test suite separately. For example, there are
several tests under contrib/ that create roles. These would not be
covered by this automatically.

I think the earlier idea of just counting roles, tablespaces, etc.
before and after would be sufficient.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2023-11-08 08:30:12 pgsql: Fix use of OPENSSL in SSL tests if command is not found
Previous Message Michael Paquier 2023-11-08 05:07:24 pgsql: Enlarge assertion in bloom_init() for false_positive_rate

Browse pgsql-hackers by date

  From Date Subject
Next Message Hayato Kuroda (Fujitsu) 2023-11-08 08:13:06 Random pg_upgrade test failure on drongo
Previous Message Xiang Gao 2023-11-08 07:44:11 Question about the Implementation of vector32_is_highbit_set on ARM