From: | Andreas Pflug <pgadmin(at)pse-consulting(dot)de> |
---|---|
To: | Hiroshi Saito <saito(at)inetrt(dot)skcapi(dot)co(dot)jp> |
Cc: | pgadmin-hackers(at)postgresql(dot)org |
Subject: | Re: pg_hba.conf can't write |
Date: | 2004-12-16 16:14:30 |
Message-ID: | 41C1B466.5070603@pse-consulting.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hiroshi Saito wrote:
>
> However, It can't change into the comment line.
> Please apply it.
>
> ------------------------------------------------------------------------
>
> --- src/ui/dlgHbaConfig.cpp.orig Thu Dec 16 02:07:11 2004
> +++ src/ui/dlgHbaConfig.cpp Thu Dec 16 02:07:39 2004
> @@ -297,7 +297,7 @@
>
> }
> btnOK->Enable(cbType->GetSelection() >= 0 && !database.IsEmpty() && !user.IsEmpty() &&
> - cbMethod->GetSelection() >= 0 && ipValid);
> + cbMethod->GetSelection() >= 0);
I don't like this fix. The check is ok, but ipValid is wrong;
preliminarily fixed.
Maybe you find the time to implement the checking code in line 298ff for
IPV4 an IPV6 and both flavours of netmasks.
Regards,
Andreas
From | Date | Subject | |
---|---|---|---|
Next Message | Raphaël Enrici | 2004-12-19 11:36:00 | pgAdmin III 1.2.0 uploaded to Debian archive |
Previous Message | cvs | 2004-12-16 16:12:25 | CVS Commit by andreas: preliminary fix for ip address checking |