Re: [HACKERS] regression script/makefile exit failure

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] regression script/makefile exit failure
Date: 2004-12-11 21:33:53
Message-ID: 41BB67C1.4040403@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Andrew Dunstan wrote:

>
>
> Peter Eisentraut wrote:
>
>>
>> I seem to recall that there is a bug in the FreeBSD shell with line
>> breaks in traps. Try changing the above to
>>
>> trap 'st=$?; echo status = $st; exit $st' 0
>>
>>
>
>
> Thankyou Peter! I'd never have guessed something so obscure!
>
> I have confirmed that this is the problem, and ascertained that the
> Cygwin shell exhibits the same behaviour.
>
> I will submit a patch for pg_regress.sh shortly (after a little
> testing using buildfarm).
>
>

Attached patch has been tested on Cygwin and found to work as expected
when initdb fails during make check - I don't have access to a FreeBSD
machine to do a test buildfarm run.

cheers

andrew

Attachment Content-Type Size
trap2.patch text/x-patch 1.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-12-11 23:28:15 Re: [HACKERS] 8.0.0beta5 FailedAssertion (Crash) when casting composite types
Previous Message Andrew Dunstan 2004-12-11 20:35:58 Re: regression script/makefile exit failure

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2004-12-11 23:28:15 Re: [HACKERS] 8.0.0beta5 FailedAssertion (Crash) when casting composite types
Previous Message Andrew Dunstan 2004-12-11 20:35:58 Re: regression script/makefile exit failure