Re: [HACKERS] pg_arch.c call to sleep()

Magnus Hagander wrote:

>>>We have the following warning on Windows:
>>>pgarch.c:349: warning: implicit declaration of function `sleep'
>>>
>>>
>>>To fix it we could include the right header (which appears to be
>>><stdlib.h> in the Windows/Mingw case), or we could replace
>>>
>>>
>>the call by
>>
>>
>>>a call to pg_usleep().
>>>
>>>
>><stdlib.h> is included automatically by c.h, so that surely
>>won't fix it.
>>
>>I have some recollection that we invented pg_usleep in part
>>because we wanted to not use sleep() at all in the backend,
>>but I don't recall why (and the reasoning might not apply to
>>the archiver process, anyway).
>>
>>
>
>win32 signal handling won't interrupt sleep(), just pg_usleep().
>
>
>
>

I take this as confirmation that calling pg_usleep is the Right Thing (tm).

Here's the patch.

cheers

andrew