From: | John A Meinel <john(at)johnmeinel(dot)com> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Win32 port list <pgsql-hackers-win32(at)postgresql(dot)org> |
Subject: | Re: [PATCHES] psql \! WIN32 cleanup |
Date: | 2004-11-06 06:10:49 |
Message-ID: | 418C6AE9.5060300@johnmeinel.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers-win32 pgsql-patches |
Bruce Momjian wrote:
> Tom Lane wrote:
>
>>Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
>>
>>>The attached applied patch tests for COMSPEC in the right place and
>>>supplies a reasonable shell default on Win32.
>>
>>>+ #define DEFAULT_SHELL "c:/windows/system32/cmd.exe"
>>
>>Is it really a good idea to assume that the Windows installation is on
>>drive C: ?
>>
>>(This is an honest question, not a rhetorical one. I dunno whether
>>inserting the C: is better than leaving it off. I can think of cases
>>where either way will break, but I'm unsure what's most likely in
>>practice.)
>
>
> Not sure. Should we just do "/windows/system32/cmd.exe" and leave off
> the C:? The previous default was "/bin/sh" and that certainly will not
> work on Win32.
>
Do you need to supply the full path to the executable? Because if it is
in the system PATH, then it should be found, and you can just do:
#define DEFAULT_SHELL "cmd.exe"
Or, if you allow environment variables, then something like:
#define DEFAULT_SHELL "$WINDIR/system32/cmd.exe"
is probably the way to go.
John
=:->
From | Date | Subject | |
---|---|---|---|
Next Message | Gaetano Mendola | 2004-11-06 09:01:46 | Re: psql \! WIN32 cleanup |
Previous Message | Bruce Momjian | 2004-11-06 05:49:56 | Re: [PATCHES] psql \! WIN32 cleanup |
From | Date | Subject | |
---|---|---|---|
Next Message | Gaetano Mendola | 2004-11-06 09:01:46 | Re: psql \! WIN32 cleanup |
Previous Message | Bruce Momjian | 2004-11-06 05:58:54 | Re: ON COMMIT and foreign keys |