Re: pg_autovacuum vacuum cost variables patch v2

From: "Matthew T(dot) O'Connor" <matthew(at)zeut(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: pg_autovacuum vacuum cost variables patch v2
Date: 2004-10-29 18:12:52
Message-ID: 41828824.4070800@zeut.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:

>"Matthew T. O'Connor" <matthew(at)zeut(dot)net> writes:
>
>
>>+ if(operation == VACUUM_ANALYZE)
>>+ update_table_thresholds(dbi, tbl, VACUUM_ANALYZE);
>>+ else if(operation == VACUUM_ANALYZE)
>>+ update_table_thresholds(dbi, tbl, ANALYZE_ONLY);
>>
>>
>
>Surely that's not right ... are there any third cases here? Why
>not just a one-liner
> update_table_thresholds(dbi, tbl, operation);
>
>
Whoops.... I think that was both a thinko and a typeo :-) Yes your one
line will work much better. I'll submit another patch in a few days,
unless someone beats me to it.

Thanks for fixing that.

Matthew

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-10-29 18:21:39 Re: Add buffer length setting
Previous Message Bruce Momjian 2004-10-29 17:52:40 Add buffer length setting