Re: Possible make_oidjoins_check Security Issue

Tom Lane wrote:

>Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>
>
>>Tom Lane wrote:
>>
>>
>>>I suspect that no one on the planet
>>>except Bruce and myself have ever actually run this script.
>>>
>>>
>
>
>
>>Then why don't we just remove it? Problem solved ...
>>
>>
>
>Because it's a needed maintenance tool. There isn't any particularly
>good reason for it to get installed as though it were an interesting
>program for users, though, so I think that this is mostly a matter of
>poor packaging choices. I am in fact intending to remove the
>contrib/findoidjoins files from the set of stuff installed by Red Hat's
>RPMs.
>
>I suppose you could make an argument for moving this directory out of
>contrib and putting it under src/tools instead, but that seems like more
>work (and loss of CVS history) than it's worth.
>
>
>
>

Then maybe there's a case for removing findoidjoins from WANTED_DIRS in
contrib/Makefile? I agree this issue is so trifling that it's not worth
spending much energy on.

On a very slightly related note, I see that ipcclean (which is a shell
script) is installed on Windows by "make install". Do we want to fix
that or trust the binary packagers to remove it?

cheers

andrew