Re: [HACKERS] strange result from contrib/seg regression on windows

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] strange result from contrib/seg regression on windows
Date: 2004-10-19 15:44:05
Message-ID: 41753645.8010301@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:

>Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>
>
>>Does anyone have a clue why?
>>
>>
>
>Evidently your sscanf isn't setting errno for overflow --- look at
>seg_atof() in segparse.y.
>
>
>This code shows several other signs of severe brain death, actually,
>like leaking 256 bytes on each call for an error message buffer that it
>doesn't even need :-( I'd recommend ripping the whole thing out and
>replacing with a call to float4in.
>
>
>
>
Patch and alternative regression result file attached (Thanks to Tom for
an assist).

cheers

andrew

Attachment Content-Type Size
seg.patch text/x-patch 2.0 KB
seg_1.out text/plain 12.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-10-19 16:01:52 Re: spinlocks: generalizing "non-locking test"
Previous Message Andrew Sullivan 2004-10-19 15:41:53 Re:

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2004-10-19 16:07:54 Re: additional GCC warning flags
Previous Message Zeugswetter Andreas DAZ SD 2004-10-19 14:09:17 Re: [PATCHES] Open Items