Re: setBinaryStream can abandon connection

From: Oliver Jowett <oliver(at)opencloud(dot)com>
To: Kris Jurka <books(at)ejurka(dot)com>
Cc: pgsql-jdbc(at)postgresql(dot)org
Subject: Re: setBinaryStream can abandon connection
Date: 2004-10-18 02:02:11
Message-ID: 41732423.1080407@opencloud.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-jdbc

Kris Jurka wrote:

> OK. So we should calculate the total message length using a "long"
> variable to guard against overflow and then check that it doesn't exceed
> MaxAllocSize. If it does, do not issue the bind at all and throw an
> Exception in a fashion that keeps the connection in working order.

Sounds reasonable.

I was wondering if it was worth teaching PGstream (or a subclass) about
the protocol format. Then it could automatically check for oversize
messages, that we wrote as much data we claimed, and that when reading a
server message we consumed the entire message. I don't know what the
overhead of doing this would be, though.

-O

In response to

Browse pgsql-jdbc by date

  From Date Subject
Next Message Simon Moses 2004-10-18 05:36:31 create view problem
Previous Message Kris Jurka 2004-10-17 21:50:22 Re: setBinaryStream can abandon connection