From: | Oliver Jowett <oliver(at)opencloud(dot)com> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | pgsql-patches(at)postgresql(dot)org |
Subject: | Re: Support LDFLAGS_SL on most ports |
Date: | 2004-10-07 23:27:31 |
Message-ID: | 4165D0E3.8020203@opencloud.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Peter Eisentraut wrote:
> Two comments: First, support for specifying it on configure requires you
> to call AC_ARG_VAR ("require" as in it would prevent people from
> shooting themselves in the foot). Please read up on it and add the
> appropriate call.
Ok, so that makes sure that the var is hooked into the
cache/autoreconfig/etc machinery. Fixed.
> Second, the AC_MSG_NOTICE calls are there for some
> variables because configure may modify them. But LDFLAGS_SL is just
> taken as given, so there is no need to print a notice about it.
Personally I find it annoying when configure eats arguments without any
feedback at all -- did it actually use the parameter, or did I make a
typo? I've removed the AC_MSG_NOTICE anyway.
Updated patch attached.
-O
Attachment | Content-Type | Size |
---|---|---|
pgsql-ldflags-sl-v2.txt | text/plain | 1.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2004-10-08 00:27:21 | Re: more dirmod CYGWIN (was: APR 1.0 released) |
Previous Message | Tom Lane | 2004-10-07 19:32:16 | Re: [PATCHES] HP-UX PA-RISC/Itanium 64-bit Patch and HP-UX |