Re: -HEAD build failure on OpenBSD 3.6-current/Sparc64

From: Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: -HEAD build failure on OpenBSD 3.6-current/Sparc64
Date: 2004-10-05 16:27:43
Message-ID: 4162CB7F.5020708@kaltenbrunner.cc
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Stefan Kaltenbrunner <mm-mailinglist(at)madness(dot)at> writes:
>
>>Tom Lane wrote:
>>
>>>Why did you remove -DPIC ?
>
>
>>uhm partly because I sent the wrong patch and partly because I didn't
>>understood what that to do anyway(in the !Sparc case). The only place I
>>can find on my machine where defining PIC seems to have an effect is in
>>/usr/include/sparc64/asm.h - so I would guess it was a no-op anyway on
>>Openbsd/!Sparc.
>
>
> It may do nothing, but since it was in there and not causing trouble,
> I think it's probably best to leave it.

agreed - leaving it in is definitely a safer approach

>
>
>>But my programming skills are somewhat limited so I would definitly need
>>some guidance on this or I will just sent another patch with adds -DPIC
>>back for both cases if you want.
>
>
> No, I can change it.

thanks

Stefan

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2004-10-05 16:35:15 Problem with Win32 pg_dump linking and symbols
Previous Message Andreas Pflug 2004-10-05 16:01:31 Re: acl_admin.sql