Re: error report on slru.c

From: Gaetano Mendola <mendola(at)bigfoot(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: error report on slru.c
Date: 2004-10-03 12:42:08
Message-ID: 415FF3A0.3090304@bigfoot.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> Gaetano Mendola <mendola(at)bigfoot(dot)com> writes:
>
>>here a patch that
>>1) Rise the information about the file missing on pg_clog from
>> detail to error
>
>
> This violates the message style guidelines, IMHO.

Tom, your opinion is not humble but is is really appreciated, however
I think that a missing file is not a "detail" information.

>>2) Insert the offset information also for a missing file
>
>
> It's hardly necessary, since the transaction number tells you everything
> you need to know if you really need it, and the offset is certainly not
> relevant to a file-open failure.

Good to know, how is possible then retrive the informations about the file
needed and the offset without rise the logs detail ?

Regards
Gaetano Mendola

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Neil Conway 2004-10-03 16:04:33 license cleanup
Previous Message Andrew Dunstan 2004-10-03 01:27:09 Re: [PATCH] 5 plperl patches