Re: Busted includes somewhere near worker_internal.h

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Busted includes somewhere near worker_internal.h
Date: 2020-07-18 18:59:18
Message-ID: 4149152.1595098758@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2020-07-17 16:09:14 -0400, Tom Lane wrote:
>> headerscheck and cpluspluscheck are both unhappy about this:
>> ./src/include/replication/worker_internal.h:49:2: error: unknown type name 'slock_t'
>> slock_t relmutex;
>> ^~~~~~~

> I think including spin.h is the right fix, given that it needs to know
> the size of s_lock.

Done that way.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ranier Vilela 2020-07-18 19:27:36 Re: CID 1428952 (#1 of 1): Out-of-bounds access (OVERRUN) (src/backend/commands/async.c)
Previous Message Tom Lane 2020-07-18 18:30:43 Re: Default setting for enable_hashagg_disk