| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Kirill Reshke <reshkekirill(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: attndims, typndims still not enforced, but make the value within a sane threshold |
| Date: | 2024-12-11 05:15:51 |
| Message-ID: | 413465.1733894151@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> FWIW, my first thought after reading this paragraph is that you sound
> too dramatic here, especially after looking at codesearch to note that
> the PHP core code stores attndims but does not actually use it.
It appeared to me that it fetches it in order to return it in an
application inquiry function [1]. So to really gauge the damage,
you'd have to find out how many PHP applications pay attention
to the "array dims" field of pg_meta_data(). Maybe it's a trivial
number, or maybe not --- I didn't have the energy to search.
regards, tom lane
[1] https://sources.debian.org/src/php8.2/8.2.26-4/ext/pgsql/pgsql.c/?hl=4245#L4245
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2024-12-11 05:17:52 | VACUUM cleaning of CF 2024-11 |
| Previous Message | Michael Paquier | 2024-12-11 05:12:17 | Re: warn if GUC set to an invalid shared library |