| From: | Ronan Dunklau <ronan(dot)dunklau(at)aiven(dot)io> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Subject: | Re: pg_receivewal starting position |
| Date: | 2021-10-21 08:36:42 |
| Message-ID: | 4126495.44csPzL39Z@aivenronan |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Le jeudi 21 octobre 2021, 09:21:44 CEST Michael Paquier a écrit :
> On Thu, Oct 21, 2021 at 08:29:54AM +0200, Ronan Dunklau wrote:
> > Ok, do you want me to propose a different patch for previous versions ?
>
> That's not necessary. Thanks for proposing.
>
> > Do you mean restart_lsn as the pointer argument to the function, or
> > restart_lsn as the field returned by the command ? If it's the first, I'll
> > change it but if it's the latter it is expected that we sometime run this
> > on a slot where WAL has never been reserved yet.
>
> restart_lsn as the pointer of the function.
Done. I haven't touched the timeline switch test patch for now, but I still
include it here for completeness.
--
Ronan Dunklau
| Attachment | Content-Type | Size |
|---|---|---|
| v10-0001-doc-Describe-calculation-method-of-streaming-sta.patch | text/x-patch | 1.8 KB |
| v10-0002-Add-READ_REPLICATION_SLOT.patch | text/x-patch | 12.4 KB |
| v10-0004-Add-tests-making-sure-pg_receivewal-can-follow-a.patch | text/x-patch | 4.2 KB |
| v10-0003-Use-READ_REPLICATION_SLOT-command-in-pg_receivew.patch | text/x-patch | 8.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-10-21 08:40:55 | Re: LogicalChanges* and LogicalSubxact* wait events are never reported |
| Previous Message | Amit Kapila | 2021-10-21 08:34:45 | Re: Failed transaction statistics to measure the logical replication progress |