From: | Nikola Milutinovic <Nikola(dot)Milutinovic(at)ev(dot)co(dot)yu> |
---|---|
To: | PgSQL General <pgsql-general(at)postgresql(dot)org> |
Subject: | PgSQL 8.0.0 beta1 compile problem + patch |
Date: | 2004-08-12 11:02:32 |
Message-ID: | 411B4E48.2000703@ev.co.yu |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-general |
Hi all.
Ran into a minor showstopper. Sometimes, my CC is just too much of a
nitpick, but on this matter, I agree with it. "./src/timezone/zic.c" has
a mismatch in declaration and definition of "memcheck(...)" function. My
CC beltched on it (I was running it in strict ANSI mode). The diference
is this:
static char *memcheck(char *tocheck);
...
/*
* Memory allocation.
*/
static char *
memcheck(ptr)
char *const ptr;
{
if (ptr == NULL)
{
const char *e = strerror(errno);
(void) fprintf(stderr, _("%s: Memory exhausted: %s\n"),
progname, e);
(void) exit(EXIT_FAILURE);
}
return ptr;
}
Notice "char *const ptr". Trusting that the lower definition is correct,
being more strict and closer to the actual code, I have changed the uper
declaration to match. I have attached a patch.
Nix.
Attachment | Content-Type | Size |
---|---|---|
PgSQL-8.0.0b1-tz-patch.diff | text/plain | 721 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Richard Huxton | 2004-08-12 11:16:20 | Re: [GENERAL] How to know which queries are to be optimised? |
Previous Message | Ulrich Wisser | 2004-08-12 10:37:44 | Re: [GENERAL] How to know which queries are to be optimised? |