From: | Andreas Pflug <pgadmin(at)pse-consulting(dot)de> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers-win32(at)postgresql(dot)org, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Subject: | Re: Win32 testing needed |
Date: | 2004-08-06 18:26:34 |
Message-ID: | 4113CD5A.6070200@pse-consulting.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers-win32 |
Tom Lane wrote:
> Andreas Pflug <pgadmin(at)pse-consulting(dot)de> writes:
>
>> ereport(LOG,
>> (errcode_for_file_access(),
>>- errmsg("could not read from logger pipe: %m")));
>>+ errmsg("could not read from logger pipe: %lu", error)));
>
>
> Does %m actually give a wrong result here? Because if it does,
> errcode_for_file_access() is wrong too.
Yes, errno is not set. Same issue for CreatePipe; I missed that.
Maybe we should consider examining GetLastError() and FormatMessage()
(the equivalent of strerror, a sample is in the symlink/junction code)
for %m under win32; these will work for standard posix operations also
and might give much more detailed messages in many situations.
Regards,
Andreas
From | Date | Subject | |
---|---|---|---|
Next Message | Andreas Pflug | 2004-08-06 18:41:40 | Re: Win32 testing needed |
Previous Message | Andreas Pflug | 2004-08-06 17:29:09 | Re: Win32 testing needed |