Re: [BUGS] casting strings to multidimensional arrays yields strange

From: Joe Conway <mail(at)joeconway(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Kris Jurka <books(at)ejurka(dot)com>, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [BUGS] casting strings to multidimensional arrays yields strange
Date: 2004-08-05 04:07:39
Message-ID: 4111B28B.6020201@joeconway.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers pgsql-patches

Tom Lane wrote:
> I had pretty much come to the conclusion that the array_in code should
> be thrown away and rewritten from the ground up --- whoever wrote it
> originally had no calling as a programmer :-(. I didn't look at the
> details of your patch, but I have little faith in half measures in this
> area. I've already wasted a lot of time trying to patch that code in
> past releases.

Agreed, but I don't think I'll be able to get that done tonight.

While looking at it the last day or so, I started to think it might be
better to use bison to parse array literals -- or is that a bad idea?

In any case, I'm planning to find the time to work on NULL array
elements as soon as we branch 8.0 from head. At that time I'll also look
at cleaning up array_in (and friends undoubtedly).

Joe

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2004-08-05 04:19:40 Re: [BUGS] casting strings to multidimensional arrays yields strange results
Previous Message Tom Lane 2004-08-05 03:51:58 Re: [BUGS] casting strings to multidimensional arrays yields strange results

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-08-05 04:08:30 Re: DROP TABLESPACE causes panic during recovery
Previous Message Bruce Momjian 2004-08-05 04:01:12 Re: DROP TABLESPACE causes panic during recovery

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2004-08-05 04:19:40 Re: [BUGS] casting strings to multidimensional arrays yields strange results
Previous Message Tom Lane 2004-08-05 03:51:58 Re: [BUGS] casting strings to multidimensional arrays yields strange results