| From: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
|---|---|
| To: | fabriziomello(at)gmail(dot)com, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Aleksandr Parfenov <a(dot)parfenov(at)postgrespro(dot)ru>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> |
| Subject: | Re: [HACKERS] [PATCH] A hook for session start |
| Date: | 2017-11-19 21:38:47 |
| Message-ID: | 410ec95b-cec2-0195-6ef5-f881c3269a3a@2ndQuadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/16/2017 10:38 PM, Fabrízio de Royes Mello wrote:
> Hi all,
>
> Attached new version of the patch fixing issues about installcheck and
> some assertions reported before (based on Michael Paquier code):
>
> https://www.postgresql.org/message-id/flat/30479(dot)1510800078%40sss(dot)pgh(dot)pa(dot)us#30479(dot)1510800078(at)sss(dot)pgh(dot)pa(dot)us
> https://www.postgresql.org/message-id/flat/20171116121823(dot)GI4628%40tamriel(dot)snowman(dot)net#20171116121823(dot)GI4628(at)tamriel(dot)snowman(dot)net
>
> Regards,
I think this:
#define IsClientBackend() \
(MyBackendId != InvalidBackendId && \
!IsAutoVacuumLauncherProcess() && \
!IsAutoVacuumWorkerProcess() && \
!am_walsender && \
!IsBackgroundWorker)
probably belongs somewhere more central. Surely this isn't the only
place that we want to be able to run such a test?
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-11-19 21:49:49 | Re: [HACKERS] [PATCH] A hook for session start |
| Previous Message | Thomas Munro | 2017-11-19 21:24:00 | Re: [HACKERS] [PATCH] Incremental sort |