Re: [HACKERS] Cannot initdb in cvs tip

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Cannot initdb in cvs tip
Date: 2004-07-28 17:34:58
Message-ID: 4107E3C2.6060301@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-hackers-win32 pgsql-patches

Bruce Momjian wrote:

>Andrew Dunstan wrote:
>
>
>>>I wanted to keep a solution that was as native to the OS as possible,
>>>but because we can't do that on Win32 and few people like the unix
>>>system call to 'rm', it is time to clean it up.
>>>
>>>One question --- why is there a sleep loop needed for unlink in your
>>>patch?
>>>
>>>
>>>
>>>
>>>
>>>
>>We will just be calling the existing pgunlink() (which has a sleep) in
>>the Windows cases, so this question becomes moot.
>>
>>
>
>Great. Thanks. Sorry I delayed addressing this for so long.
>
>

Please check the enclosed patch to see if it does what you want.

>Should we look at replacing cp/copy in 7.6?
>
>
>

probably. Put it as a possible TODO maybe.

cheers

andrew

Attachment Content-Type Size
rmtree.patch text/x-patch 8.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-07-29 00:19:17 try/catch macros for Postgres backend
Previous Message Tom Lane 2004-07-28 16:58:52 Re: [HACKERS] Point in Time Recovery

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Keith Woodell 2004-07-28 18:07:26 triggers in latest snapshot
Previous Message Jacob Hanson 2004-07-28 17:25:32 Older snapshots

Browse pgsql-patches by date

  From Date Subject
Next Message Andreas Pflug 2004-07-28 21:09:43 Re: logger subprocess
Previous Message Tom Lane 2004-07-28 16:58:52 Re: [HACKERS] Point in Time Recovery