From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: Generate fmgr prototypes automatically |
Date: | 2017-01-17 19:46:53 |
Message-ID: | 40b53c62-4cf6-2d79-4aaa-c76a76532caa@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On 1/17/17 2:35 PM, Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>> Generate fmgr prototypes automatically
>
> BTW, now that I've looked through this patch ... why does it add
>
> +#include "nodes/nodes.h"
> +#include "nodes/pg_list.h"
>
> to utils/builtins.h? AFAICS that shouldn't be necessary, since
> there are no declarations in builtins.h that weren't there before.
> And seeing that this results in builtins.h being included in even more
> places than before, surely we want to minimize that file's inclusion
> footprint.
There are things in builtins.h that technically need those declarations.
It seems to work without it now, but at some point during the
refactoring they were necessary. I can remove them again.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2017-01-17 19:50:10 | pgsql: Fix typo |
Previous Message | Tom Lane | 2017-01-17 19:35:28 | Re: pgsql: Generate fmgr prototypes automatically |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2017-01-17 20:07:48 | Re: pgsql: Generate fmgr prototypes automatically |
Previous Message | Tom Lane | 2017-01-17 19:35:28 | Re: pgsql: Generate fmgr prototypes automatically |