| From: | Andreas Pflug <pgadmin(at)pse-consulting(dot)de> |
|---|---|
| To: | Magnus Hagander <mha(at)sollentuna(dot)net> |
| Cc: | PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: logfile subprocess and Fancy File Functions |
| Date: | 2004-07-19 10:54:17 |
| Message-ID: | 40FBA859.2000709@pse-consulting.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Magnus Hagander wrote:
> Super-minor nitpicking from just eyeing over the patch, not actually
> checking how it works.
Reviewing the own code the most obvious things are overlooked.
>
> This patch changes the error message for pg_signal_backend() to "only
> superuser may access generic file functions".
>
> I'm sure that was not intended.. You probably need to pass a parameter
> to requireSuperuser() about what should go in the err msg.
Yes, seems I was a bit overenthusiastic...
>
> Also, I think you forgot to attach syslogger.h.
Indeed, attached is include/postmaster/syslogger.h
Regards,
Andreas
| Attachment | Content-Type | Size |
|---|---|---|
| syslogger.h | text/x-chdr | 620 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | a_ogawa00 | 2004-07-19 13:24:42 | regexp_replace |
| Previous Message | Simon Riggs | 2004-07-19 07:35:05 | Re: [HACKERS] Point in Time Recovery |