| From: | Andreas Pflug <pgadmin(at)pse-consulting(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL Hackers Mailing List <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Bug with view definitions? |
| Date: | 2004-07-06 08:42:21 |
| Message-ID: | 40EA65ED.7070402@pse-consulting.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andreas Pflug wrote:
> Christopher Kings-Lynne wrote:
>
>>>> need_paren = (PRETTY_PAREN(context) ?
>>>> !IsA(op->rarg, RangeTblRef) : true);
>>>
>>>
>>>
>>>
>>> In a quick glance this code seems close to completely brain dead :-(
>>
This probably was about catching
expr_A UNION (expr_B INTERSECT expr_C)
cases, falsely assuming left-to-right won't ever need parentheses.
Apparently the current version already fixes this completely,
suppressing parentheses also with non-pretty.
Regards,
Andreas
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christopher Kings-Lynne | 2004-07-06 09:00:06 | bug in DROP TABLESPACE |
| Previous Message | Zeugswetter Andreas SB SD | 2004-07-06 08:11:03 | Re: subtransactions and FETCH behaviour (was Re: PREPARE and transactions) |