Re: Fixing pg_dump

From: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fixing pg_dump
Date: 2004-06-25 03:25:21
Message-ID: 40DB9B21.1010508@familyhealth.com.au
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>>I intend to make new archives created with 7.5 pg_dump have the fix, and
>> restoring pre 7.5 binary dumps will have exactly the previous
>>behaviour. The reason for this is that extracting the acls and owners
>>to the end requires scanning the entire archive twice - not necessarily
>>something we want to do (is it?)
>
> I might be wrong about this, but I had the idea that the entire archive
> TOC gets loaded into memory, and so there'd be no noticeable penalty in
> scanning it twice.

Well, it probably gets scanned twice to do -c mode?

But...it seems kind of hacky to scan it again for owners and privs - are
you sure you want me to go that way?

Chris

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-06-25 03:30:55 Re: Fixing pg_dump
Previous Message Greg Sabino Mullane 2004-06-25 02:00:12 Re: [Re] Re: PREPARE and transactions