From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | pgsql-patches(at)postgresql(dot)org |
Subject: | Re: pg_autovacuum integration patch |
Date: | 2004-06-16 14:21:27 |
Message-ID: | 40D05767.3060802@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Tom Lane wrote:
>"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
>
>
>>I also noticed:
>>! elog(ERROR, "pg_autovacuum: GUC variable stats_row_level
>>must be enabled.");
>>! elog(ERROR, " Please fix the problems and try
>>again.");
>>
>>
>
>
>
>>If you use the ereport() call instead of elog, you can set the second
>>one as a HINT. Since it's really the same error, I don't think you want
>>multiple errors logged...
>>
>>
>
>Even more to the point, control will never *reach* the second elog().
>Matthew clearly needs to spend more time studying the backend error
>message reporting mechanism. There is some documentation here:
>http://developer.postgresql.org/docs/postgres/error-message-reporting.html
>and the backend code is certainly chock-full of examples.
>
>
>
Perhaps it's just as well that it isn't reached :-) "Please fix the
problems and try again" doesn't strike me as a very useful message.
cheers
andrew
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2004-06-16 15:07:59 | Re: pg_ctl service integration for WIN32 |
Previous Message | Matthew T. O'Connor | 2004-06-16 14:08:29 | Re: pg_autovacuum integration patch |