Re: pgsql-server/src backend/utils/adt/acl.c inclu ...

From: Jan Wieck <JanWieck(at)Yahoo(dot)com>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Neil Conway <neilc(at)samurai(dot)com>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql-server/src backend/utils/adt/acl.c inclu ...
Date: 2004-05-12 20:32:24
Message-ID: 40A289D8.10104@Yahoo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Fabien COELHO wrote:

>> OK, patch reverted at request of Tom and Peter. Please propose a more
>> generalitzed soluion. Thanks.
>
> Sigh.
>
> You refuse a 10 lines patch to access a stupid opaque type in the backend.
> You both refuse some things to be done in the back end, and also to add
> what is needed to do it in userland. Moreover, I don't think this patch
> did hurt anybody, as it was pretty invisible and was useful to me.

The point where it will hurt is not now, but when or if we need to
change the internal implementation of the entire rights system. Because
at the time we rip out the whole ACL, you or somebody else will ask
absolutely justified for backward compatibility. The reason to keep
things as opaque is the freedom this gives to change implementation
details without asking if it could possibly break existing code.

>
> I'm tired. When I'll be too tired, you'll just lose a contributor. A very
> small loss indeed, but I don't think it is a good policy for your project.

I do understand the frustration, but I hope you understand the larger
scale of problems that would be created if your patch got accepted.

Jan

--
#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me. #
#================================================== JanWieck(at)Yahoo(dot)com #

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2004-05-12 21:56:27 pgsql-server/src Makefile.shlib
Previous Message Bruce Momjian 2004-05-12 13:38:49 pgsql-server/src backend/postmaster/postmaster ...

Browse pgsql-hackers by date

  From Date Subject
Next Message Shachar Shemesh 2004-05-12 20:36:49 Re: Probably security hole in postgresql-7.4.1
Previous Message Larry Rosenman 2004-05-12 20:32:05 Re: threads stuff/UnixWare