Re: "Not safe to send CSV data" message

From: Greg Stark <gsstark(at)mit(dot)edu>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: "Not safe to send CSV data" message
Date: 2009-11-22 21:37:33
Message-ID: 407d949e0911221337x4b66ecd5i8a00eee531861506@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Nov 19, 2009 at 3:50 AM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> I'm fine with that. I don't remember whether I put that in or whether it
> came from the original patch author(s). Either way, I assume the reason was
> to explain why the message appeared on stderr rather than the CSVlog. Now we
> have a couple of years of experience with CSVlog I agree it's not needed (if
> it were we'd probably have had more complaints like yours anyway).

ISTM the danger is that someone looks at the regular logs and isn't
aware that some messages went to someplace else. In which case
bleating t
to the someplace else is unhelpful. Perhaps it would be more useful if
it set a flag and then once the regular logs are set up you output a
regular warning that some errors were generated prior to switching and
were sent to stderr.

--
greg

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thom Brown 2009-11-22 21:40:32 Re: Updating column on row update
Previous Message Christophe Pettus 2009-11-22 21:27:10 Re: Updating column on row update