| From: | Greg Stark <gsstark(at)mit(dot)edu> |
|---|---|
| To: | Marko Tiikkaja <marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Query::targetList and RETURNING |
| Date: | 2009-11-10 15:11:40 |
| Message-ID: | 407d949e0911100711k76269c9di28ca70def327aa5@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 10, 2009 at 2:56 PM, Marko Tiikkaja
<marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi> wrote:
> (Sorry, forgot to CC the list)
>
> Tom Lane wrote:
>>
>> This doesn't really seem like a good idea from here. You're changing
>> a decision that has something like twenty years' standing in the code,
>> for no real gain. AFAICS this is just going to move the special cases
>> from point A to point B.
>
> Right, but this way you only have to special-case in grouping_planner(),
> and targetList always means the same thing.
I haven't read through the patch but I can say the existing
arrangement certainly seemed strange to me when I first saw it.
--
greg
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2009-11-10 15:11:49 | Re: Parsing config files in a directory |
| Previous Message | Tom Lane | 2009-11-10 15:08:42 | Re: Query::targetList and RETURNING |