From: | Greg Stark <stark(at)mit(dot)edu> |
---|---|
To: | "<pgsql-hackers(at)postgresql(dot)org>" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: join removal |
Date: | 2009-07-17 01:02:06 |
Message-ID: | 407d949e0907161802w11b92a47j4076f5c086090cce@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
I started looking at this patch and it looks pretty good as far as it
goes. But I think we can do a lot more. It seems to me the cases where
foreign key relationships exist are likely to be really big use cases.
I have one big worry though. Currently you're detecting the unique
property using the planner's path mechanism. I suppose that works, but
it's only an accident of the planner design that the path for the
unique index will always be there if it's the join condition. My
instinct is that this code should be going back to the raw index info
to prove this property. The only practical effect I can think of is
that the plan will have to be marked as being dependent on that index
and that will be hard to do if you haven't identified a specific index
you're basing it on.
I would like to see a list of cases we plan to tackle preferably with
example queries, as a kind of checklist so we can knock them down one
by one. Right now it's unclear just how much of the problem space is
being solved.
Incidentally, guess what other database just got this feature committed...
From | Date | Subject | |
---|---|---|---|
Next Message | KaiGai Kohei | 2009-07-17 01:36:11 | Re: [PATCH] [v8.5] Security checks on largeobjects |
Previous Message | Andrew Dunstan | 2009-07-17 00:58:47 | Re: Docbook toolchain interfering with patch review? |