| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
| Cc: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Florian Pflug <fgp(at)phlo(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Erik Rijkers <er(at)xs4all(dot)nl>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Range Types - typo + NULL string constructor |
| Date: | 2011-10-09 16:06:34 |
| Message-ID: | 4067.1318176394@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Jeff Davis <pgsql(at)j-davis(dot)com> writes:
> On Sat, 2011-10-08 at 12:44 -0700, Jeff Janes wrote:
>> When I apply this to head, "make check" fails with:
>>
>> create type textrange_en_us as range(subtype=text, collation="en_US");
>> + ERROR: collation "en_US" for encoding "SQL_ASCII" does not exist
> Thank you for pointing that out. I think I need to remove those before
> commit, but I just wanted them in there now to exercise that part of the
> code.
> Is there a better way to test collations like that?
You could add some code that assumes particular collations are present
into collate.linux.utf8.sql. It's not going to work to depend on
anything beyond C locale being present in a mainline regression test
case.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Florian Pflug | 2011-10-09 17:10:23 | Re: libpq, PQdescribePrepared -> PQftype, PQfmod, no PQnullable |
| Previous Message | Heikki Linnakangas | 2011-10-09 16:01:07 | Re: REVIEW: Optimizing box_penalty |