| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Amit Kapila <akapila(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Remove unused wait events. |
| Date: | 2021-10-25 16:38:38 |
| Message-ID: | 4047667.1635179918@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Wed, Oct 20, 2021 at 10:52 PM Amit Kapila <akapila(at)postgresql(dot)org> wrote:
>> Remove unused wait events.
> This commit forces a recompile of every extension that knows about the
> integer values assigned to the enums in WaitEventIO. I know of 2
> extensions that are affected by this. I think that it should be
> reverted in v14 and kept only in master.
Um ... the removed symbols were at the end of the WaitEventIO enum,
so is there really an ABI break? I suppose if an extension contains
actual references to the removed symbols, it would fail to recompile,
which'd be annoying for a released branch.
On the whole, I agree that this patch had no business being committed
to v14.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2021-10-25 17:10:25 | Re: pgsql: Remove unused wait events. |
| Previous Message | Robert Haas | 2021-10-25 16:17:53 | Re: pgsql: Remove unused wait events. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-10-25 16:43:15 | Re: pg_dump versus ancient server versions |
| Previous Message | Stephen Frost | 2021-10-25 16:26:13 | Re: parallelizing the archiver |