From: | Neil Conway <neilc(at)samurai(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-patches(at)postgresql(dot)org |
Subject: | Re: tighten input to float4/float8/oid |
Date: | 2004-03-04 04:44:19 |
Message-ID: | 4046B423.8000700@samurai.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Tom Lane wrote:
> I think this is wrong. We silently accept leading whitespace in
> (IIRC) all the numeric datatypes, and I believe we should accept
> trailing whitespace too.
(Sorry, I had misremembered your suggestion -- you had earlier said
that the spec probably allows for leading and trailing whitespace.)
I think there's a case to be made that we shouldn't accept either
leading or trailing whitespace, but it seems too late to go down that
path: it isn't worth breaking backward compatibility over, for one thing.
So if we're going to continue to accept leading whitespace, it seems
only reasonable to consistently accept trailing whitespace as well.
> Minor stylistic gripe here: errdetail and errhint messages are
> supposed to be complete sentences
Thanks for catching that, I'll fix it before applying.
I'll apply the patch this evening without the trailing whitespace
change; if there's a consensus that allowing trailing whitespace is
the best course, I'll post a separate patch for that shortly.
-Neil
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2004-03-04 04:58:14 | Re: tighten input to float4/float8/oid |
Previous Message | Tom Lane | 2004-03-04 04:07:07 | Re: minor doc improvements |