Re: log_line_info

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: log_line_info
Date: 2004-03-02 01:32:43
Message-ID: 4043E43B.2020905@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Jon Jensen wrote:

>On Sun, 29 Feb 2004, Andrew Dunstan wrote:
>
>
>
>>. changed source port reporting from host:port to host(port) to avoid
>>IP6 address ambiguity.
>>
>>
>
>I have no idea how widespread this is, but recent versions of BIND write
>it this way:
>
>127.0.0.1#953
>::1#953
>
>Personally I'd kind of like to see host:port for IPv4 (for familiarity)
>and host#port for IPv6 (for clarity), but I don't know that it's worth
>spending much time on.
>

host might be a name instead of an address (if you have log_host_name
turned on), so I'm not inclined to distinguish between address families.
Altering the format used would be a 2 line change. (I hope the patch
isn't held up over that issue).

>
>Excellent patch, though.
>

thanks

cheers

andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruno Wolff III 2004-03-02 01:43:59 Re: [HACKERS] CHECK constraints inconsistencies
Previous Message Tom Lane 2004-03-02 01:30:39 Re: Avoid MVCC using exclusive lock possible?

Browse pgsql-patches by date

  From Date Subject
Next Message Fabien COELHO 2004-03-02 08:45:55 Re: [PATCHES] Foreign key type checking patch
Previous Message Jon Jensen 2004-03-01 21:38:37 Re: log_line_info