Re: may be a mismatch between the construct_array and construct_md_array comments

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alena Rybakina <a(dot)rybakina(at)postgrespro(dot)ru>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: may be a mismatch between the construct_array and construct_md_array comments
Date: 2024-09-12 17:44:11
Message-ID: 4039567.1726163051@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alena Rybakina <a(dot)rybakina(at)postgrespro(dot)ru> writes:
> I noticed that there is a comment that values ​​with NULL are not
> processed there, but in fact this function calls the construct_md_array
> function, which
> contains a comment that it can handle NULL values.

Right. construct_md_array has a "bool *nulls" argument, but
construct_array doesn't --- it passes NULL for that to
construct_md_array, which will therefore assume there are no null
array elements.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2024-09-12 20:01:45 Re: tiny step toward threading: reduce dependence on setlocale()
Previous Message Christoph Berg 2024-09-12 15:46:55 Re: [PATCH] Extend ALTER OPERATOR to support adding commutator, negator, hashes, and merges