| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Devrim Gündüz <devrim(at)gunduz(dot)org>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: GCC 8 warnings |
| Date: | 2018-06-16 19:00:11 |
| Message-ID: | 4039.1529175611@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2018-06-16 13:29:55 -0400, Tom Lane wrote:
>> + # Similarly disable useless truncation warnings from gcc 8+
>> + PGAC_PROG_CC_VAR_OPT(NOT_THE_CFLAGS, [-Wformat-truncation])
>> + if test -n "$NOT_THE_CFLAGS"; then
>> + CFLAGS="$CFLAGS -Wno-format-truncation"
>> + fi
>> + PGAC_PROG_CC_VAR_OPT(NOT_THE_CFLAGS, [-Wstringop-truncation])
>> + if test -n "$NOT_THE_CFLAGS"; then
>> + CFLAGS="$CFLAGS -Wno-stringop-truncation"
>> + fi
> I've not had a lot of coffee yet this morning, but couldn't there be an
> issue where a compiler supported one of these flags? Because
> NOT_THE_CFLAGS is reused, it'd trigger lateron as well, right? Seems to
> me we'd need to reset it.
Yeah, I found that out as soon as I checked this on another platform ;-).
Will fix.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-06-16 19:02:10 | Re: WAL prefetch |
| Previous Message | Andres Freund | 2018-06-16 18:52:18 | Re: GCC 8 warnings |