| From: | Nikolay Shaplov <dhyan(at)nataraj(dot)su> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Robert Treat <rob(at)xzilla(dot)net>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Albe <laurenz(dot)albe(at)cybertec(dot)at>, Gurjeet Singh <gurjeet(at)singh(dot)im>, Will Storey <will(at)summercat(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: vacuum_truncate configuration parameter and isset_offset |
| Date: | 2025-03-24 19:35:41 |
| Message-ID: | 4028577.Y6S9NjorxK@thinkpad-pgpro |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
В письме от понедельник, 24 марта 2025 г. 22:26:17 MSK пользователь Nathan
Bossart написал:
> > And second general idea: changing engine is bad, at least when you can
> > manage without changing it.
>
> You have asserted this a couple of times without providing any reasons why.
> I know of no general project policy about changing the reloption code. I
> would expect this code to evolve just like any other part of Postgres,
> whether it's to improve performance or to expand the feature set.
Because this code was carefully designed, and it is intentionally was made the
way it is.
It can be redesigned, but redesigning is not just adding another field to a C
structure. It requires very carefully consideration, not as a part of option
patch, but as a redesign patch. See my answer to Robert. We can have
isset_offset, but then we have redesign all options with custom unset behavior
to use it, instead of unreachable default value. This will make it consistent
then.
--
Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sami Imseih | 2025-03-24 19:36:05 | Re: Proposal - Allow extensions to set a Plan Identifier |
| Previous Message | Rahila Syed | 2025-03-24 19:31:36 | Re: Prevent an error on attaching/creating a DSM/DSA from an interrupt handler. |