Re: win32 inode fix

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: pgsql-patches(at)postgresql(dot)org
Subject: Re: win32 inode fix
Date: 2004-02-09 21:15:04
Message-ID: 4027F858.8060704@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Bruce Momjian wrote:

>Neil Conway wrote:
>
>
>>Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
>>
>>
>>>In reading the patch, it seems he is only doing "zero equals
>>>unknown" on Win32, so I think we are fine.
>>>
>>>
>>That's what I was trying to avoid: where possible, we shouldn't
>>introduce platform-dependent #ifdefs IMHO.
>>
>>
>
>But the platform doesn't give us what we want so I don't see why we
>should weaken other platforms just for consistency.
>
>

Surely the operative words are "where possible". Looks like this is one
case where it is not reasonably possible. I don't think we will ever be
totally rid of them. I tried quite hard to keep them to a minimum in
initdb, but eliminating them was not really an option.

cheers

andrew

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-02-09 21:43:28 Re: [PATCHES] win32 signals, part 5
Previous Message Jeroen T. Vermeulen 2004-02-09 20:56:30 Re: Two-phase commit