| From: | Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: It's past time to redo the smgr API |
| Date: | 2004-02-06 01:11:25 |
| Message-ID: | 4022E9BD.2020900@familyhealth.com.au |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> * AFAICS the only downside of not having a Relation available in smgr.c
> and md.c is that error messages could only refer to the RelFileNode
> numbers and not to the relation name. I'm not sure this is bad, since
> in my experience what you want to know about such errors is the actual
> disk filename, which RelFileNode tells you and relation name doesn't.
> We could preserve the current behavior by passing the relation name to
> smgropen when available, and saving the name in struct SMgrRelation.
> But I'm inclined not to.
>
> Comments?
That all sounds pretty nice. From my point of view I recall you saying
that this would need to be done for tablespaces a long time ago - so I
just request that the rewrite be done with future tablespaces in mind :)
Chris
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Slavisa Garic | 2004-02-06 02:52:28 | Re: COPY with INDEXES question |
| Previous Message | Slavisa Garic | 2004-02-06 00:46:57 | COPY with INDEXES question |