From: | Mike Charnoky <noky(at)nextbus(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-general(at)postgresql(dot)org |
Subject: | Re: pg_restore and large files |
Date: | 2004-02-05 21:40:13 |
Message-ID: | 4022B83D.2070002@nextbus.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-general |
Excellent! This indeed solves the problem. I'll recompile pg_dump as well,
just to be on the safe side.
Thank you so much Tom for your quick response.
Mike Charnoky
Tom Lane wrote:
> Mike Charnoky <noky(at)nextbus(dot)com> writes:
>
>>So, it does look like a pg_restore bug and that dataPos is
>>being treated as an integer somewhere.
>
>
> After digging in the CVS log I bet this is the same bug just noted a
> month ago:
>
> 2004-01-03 23:02 tgl
>
> * src/bin/pg_dump/: pg_backup_archiver.c (REL7_4_STABLE),
> pg_backup_archiver.c: Fix ReadOffset() to work correctly when off_t
> is wider than int.
>
> It looks like the same patch applies to 7.3, modulo slightly different
> line number. Please try it and let us know if it fixes the problem.
>
> regards, tom lane
>
> ===================================================================
> RCS file: /cvsroot//pgsql-server/src/bin/pg_dump/pg_backup_archiver.c,v
> retrieving revision 1.79
> retrieving revision 1.79.2.1
> diff -c -r1.79 -r1.79.2.1
> *** pgsql-server/src/bin/pg_dump/pg_backup_archiver.c 2003/10/20 21:05:11 1.79
> --- pgsql-server/src/bin/pg_dump/pg_backup_archiver.c 2004/01/04 04:02:22 1.79.2.1
> ***************
> *** 1425,1431 ****
> for (off = 0; off < AH->offSize; off++)
> {
> if (off < sizeof(off_t))
> ! *o |= ((*AH->ReadBytePtr) (AH)) << (off * 8);
> else
> {
> if ((*AH->ReadBytePtr) (AH) != 0)
> --- 1425,1431 ----
> for (off = 0; off < AH->offSize; off++)
> {
> if (off < sizeof(off_t))
> ! *o |= ((off_t) ((*AH->ReadBytePtr) (AH))) << (off * 8);
> else
> {
> if ((*AH->ReadBytePtr) (AH) != 0)
>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
>
> http://archives.postgresql.org
>
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2004-02-05 22:14:13 | Re: pg_restore and large files |
Previous Message | Marc G. Fournier | 2004-02-05 21:09:42 | Re: size of mailing lists? |