Re: Testing pg_terminate_backend()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Testing pg_terminate_backend()
Date: 2008-04-18 17:24:10
Message-ID: 4020.1208539450@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Attached is my test script. I ran it for 14 hours (asserts on),
> running 450 regression tests, with up to seven backends killed per
> regression test.

Hmm, there are something on the order of 10000 SQL commands in our
regression tests, so even assuming perfect randomness you've exercised
SIGTERM on maybe 10% of them --- and of course there's multiple places
in a complex DDL command where SIGTERM might conceivably be a problem.

Who was volunteering to run this 24x7 for awhile?

> SLEEP=`expr $RANDOM \* $REGRESSION_DURATION / 32767`

Uh, where's the randomness coming from?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Naz Gassiep 2008-04-18 17:37:26 Re: get rid of psql welcome message
Previous Message Bruce Momjian 2008-04-18 16:53:43 Testing pg_terminate_backend()

Browse pgsql-patches by date

  From Date Subject
Next Message Bryce Nesbitt 2008-04-18 18:46:12 Re: [PATCHES] Coding standards
Previous Message Bruce Momjian 2008-04-18 16:53:43 Testing pg_terminate_backend()