| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Mismatch in libpqwalreceiver |
| Date: | 2010-03-24 01:02:27 |
| Message-ID: | 3f0b79eb1003231802u1f4c127fk3ca214d803dbd0ae@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 24, 2010 at 1:49 AM, Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> wrote:
> There's a mismatch in HEAD between README and the actual definition in
> replication/libpqwalreceiver.
>
> In README,
>
> bool walrcv_receive(int timeout, XLogRecPtr *recptr, char **buffer, int *len)
>
> but in walreceiver.h,
>
> typedef bool (*walrcv_receive_type) (int timeout, unsigned char *type,
> char **buffer, int *len);
>
>
> It seems this commit forgot README fix.
>
> http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/replication/walreceiver.h?r1=1.5&r2=1.6
Thanks for the report! That is my mistake. Here is the patch.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| walreceiver_readme_v1.patch | application/octet-stream | 638 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2010-03-24 01:51:32 | Re: Proposal: access control jails (and introduction as aspiring GSoC student) |
| Previous Message | Fujii Masao | 2010-03-24 00:47:35 | Re: booleans in recovery.conf |