From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
---|---|
To: | pgsql-bugs(at)postgresql(dot)org |
Subject: | Re: BUG #4752: sourceline in pg_settings indicates wrong number |
Date: | 2009-04-09 10:39:58 |
Message-ID: | 3f0b79eb0904090339s28f87612q70f97efeb528d58a@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
Hi,
On Thu, Apr 9, 2009 at 1:40 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> The following bug has been logged online:
>
> Bug reference: 4752
> Logged by: Fujii Masao
> Email address: masao(dot)fujii(at)gmail(dot)com
> PostgreSQL version: PostgreSQL 8.4d
> Operating system: Red Hat Enterprise Linux Server release 5.1 (Tikanga)
> Description: sourceline in pg_settings indicates wrong number
> Details:
>
> Hi,
>
> sourceline (in pg_settings) of the parameter line without '\n' indicates
> wrong number as follows.
>
> $ nl $PGDATA/postgresql.conf
> 1 shared_buffers = 32MB <-- this line doesn't contain '\n'
> $ psql -c "SELECT sourceline FROM pg_settings WHERE name =
> 'shared_buffers'"
> sourceline
> ------------
> 0
> (1 row)
>
> On the other hand, if the line has '\n', sourceline indicates the correct
> number.
>
> $ echo "shared_buffers = 32MB" > $PGDATA/postgresql.conf
> $ nl $PGDATA/postgresql.conf
> 1 shared_buffers = 32MB <-- this line contains '\n'
> $ psql -c "SELECT sourceline FROM pg_settings WHERE name =
> 'shared_buffers'"
> sourceline
> ------------
> 1
> (1 row)
>
> Is this bug?
Attached patch fixes the bug. Is this worth committing?
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
Attachment | Content-Type | Size |
---|---|---|
sourceline_0409.patch | text/x-patch | 2.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2009-04-09 14:22:56 | Re: BUG #4752: sourceline in pg_settings indicates wrong number |
Previous Message | Fujii Masao | 2009-04-09 04:40:03 | BUG #4752: sourceline in pg_settings indicates wrong number |