From: | "Fujii Masao" <masao(dot)fujii(at)gmail(dot)com> |
---|---|
To: | "Heikki Linnakangas" <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
Cc: | "Bruce Momjian" <bruce(at)momjian(dot)us>, "Randy Isbell" <jisbell(at)cisco(dot)com>, pgsql-bugs(at)postgresql(dot)org |
Subject: | Re: BUG #4566: pg_stop_backup() reports incorrect STOP WAL LOCATION |
Date: | 2009-01-15 14:15:55 |
Message-ID: | 3f0b79eb0901150615g133f845erc39faf19793d5977@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-docs pgsql-hackers |
Hi,
On Thu, Jan 15, 2009 at 9:09 PM, Heikki Linnakangas
<heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> I think not
> (http://archives.postgresql.org/pgsql-hackers/2008-12/msg00126.php) The
> return value of pg_stop_backup() is currently the same as
> pg_switch_xlog()'s: the location of the last byte before the XLOG switch +
> 1. The proposed patch would remove the "+ 1". Seems like an unnecessary API
> change, and I don't recall any reason why the new definition would be
> better.
My patch doesn't change the return value of pg_stop_backup(), it's still
the same as the return value of pg_switch_xlog(). Only a part of backup
history file (the file name including stop wal location) is changed.
Currently, the file name is wrong if stop wal location indicates a boundary
byte. This would confuse the user, I think.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2009-01-15 14:25:29 | Re: BUG #4566: pg_stop_backup() reports incorrect STOP WAL LOCATION |
Previous Message | Milen A. Radev | 2009-01-15 14:00:47 | Re: BUG #4616: Create Database with another encoding as the encoding from postgres |
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2009-01-15 14:25:29 | Re: BUG #4566: pg_stop_backup() reports incorrect STOP WAL LOCATION |
Previous Message | Heikki Linnakangas | 2009-01-15 12:09:57 | Re: BUG #4566: pg_stop_backup() reports incorrect STOP WAL LOCATION |
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2009-01-15 14:25:29 | Re: BUG #4566: pg_stop_backup() reports incorrect STOP WAL LOCATION |
Previous Message | A. Kretschmer | 2009-01-15 14:06:47 | Question regarding new windowing functions in 8.4devel |