Re: Extensibility of the PostgreSQL wire protocol

On 2/19/21 4:36 AM, Kuntal Ghosh wrote:
> On Thu, Feb 18, 2021 at 9:32 PM Jan Wieck <jan(at)wi3ck(dot)info> wrote:

> Few comments in the extension code (although experimental):
>
> 1. In telnet_srv.c,
> + static int pe_port;
> ..
> + DefineCustomIntVariable("telnet_srv.port",
> + "Telnet server port.",
> + NULL,
> + &pe_port,
> + pe_port,
> + 1024,
> + 65536,
> + PGC_POSTMASTER,
> + 0,
> + NULL,
> + NULL,
> + NULL);
>
> The variable pe_port should be initialized to a value which is > 1024
> and < 65536. Otherwise, the following assert will fail,
> TRAP: FailedAssertion("newval >= conf->min", File: "guc.c", Line:
> 5541, PID: 12100)
>
> 2. The function pq_putbytes shouldn't be used by anyone other than
> old-style COPY out.
> + pq_putbytes(msg, strlen(msg));
> Otherwise, the following assert will fail in the same function:
> /* Should only be called by old-style COPY OUT */
> Assert(DoingCopyOut);
>

Attached are an updated patch and telnet_srv addressing the above problems.

Regards, Jan

--
Jan Wieck
Principle Database Engineer
Amazon Web Services