Re: [PATCH] Implement motd for PostgreSQL

On Sat, Apr 3, 2021, at 17:50, Fabien COELHO wrote:
> > Perhaps the configuration-file parser has been fixed since to support
> > embedded newlines? If so, then maybe it would actually be an idea to
> > support newlines by escaping them?
>
> Dunno.
>
> If such a feature gets considered, I'm not sure I'd like to actually edit
> pg configuration file to change the message.

For the ALTER SYSTEM case, the value would be written to postgresql.auto.conf,
and that file we shouldn't edit manually anyway, right?

>
> The actual source looks pretty straightforward. I'm wondering whether pg
> style would suggest to write motd != NULL instead of just motd.

That's what I had originally, but when reviewing my code verifying code style,
I noticed the other case it more common:

if \([a-z]* != NULL &&
119 results in 72 files

if \([a-z]* &&
936 results in 311 files

>
> I'm wondering whether it should be possible to designate (1) a file the
> content of which would be shown, or (2) a command, the output of which
> would be shown [ok, there might be security implications on this one].

Can't we just do that via plpgsql and EXECUTE somehow?

/Joel