Re: pgsql: Fix signal handling in logical replication workers

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix signal handling in logical replication workers
Date: 2017-06-05 12:27:47
Message-ID: 3d180d7b-d8a2-7f73-3237-80aed590a8e6@2ndQuadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 06/02/2017 09:13 PM, Petr Jelinek wrote:
> On 03/06/17 02:59, Tom Lane wrote:
>> I wrote:
>>> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>>>> Fix signal handling in logical replication workers
>>> It looks like this broke buildfarm member nightjar.
>>> Not clear why - I don't see anything especially platform-specific
>>> in the patch.
>> To muddy the waters further, I tried to duplicate the failure on
>> FreeBSD 11.0/x86_64, and it seems to pass just fine. Maybe Andrew
>> can look into why nightjar is failing.
>>
> There is still one locking patch pending (well pending to be written), I
> would not be surprised if there is race condition in shutdown somewhere
> before that's done.
>

nightjar has been having intermittent failures on the subscription tests
for some time. See
<https://buildfarm.postgresql.org/cgi-bin/show_history.pl?nm=nightjar&br=HEAD>.
It's only been running the tests for about 53 days.

I'm prepared to give any help needed, including access to nightjar if
required.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-06-05 16:05:48 pgsql: Don't be so trusting that shm_toc_lookup() will always succeed.
Previous Message Heikki Linnakangas 2017-06-05 08:39:27 pgsql: Fix typo in error message.