| From: | Andrei Lepikhov <lepihov(at)gmail(dot)com> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Richard Guo <guofenglinux(at)gmail(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Michał Kłeczek <michal(at)kleczek(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Removing unneeded self joins |
| Date: | 2024-12-11 09:02:32 |
| Message-ID: | 3c83675a-fdc5-4908-8584-fdc874f5fced@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 9/12/2024 13:03, Alexander Korotkov wrote:
> remove_self_join_rel(). Should we better add comments to PlannerInfo
> and other relevant structures saying: if you're going to modify this,
> consider how that affects remove_self_join_rel()?
>
> Any thoughts?
As I see, it is quite typical to keep two parts of the code in sync by
mentioning them in comments (see reparameterisation stuff, for example).
This would reduce the code needed to implement the feature.
--
regards, Andrei Lepikhov
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chiranmoy.Bhattacharya@fujitsu.com | 2024-12-11 09:06:15 | Re: [PATCH] SVE popcount support |
| Previous Message | Zhijie Hou (Fujitsu) | 2024-12-11 09:02:19 | RE: Conflict detection for update_deleted in logical replication |