From: | "Joel Jacobson" <joel(at)compiler(dot)org> |
---|---|
To: | "Michael Paquier" <michael(at)paquier(dot)xyz>, "jian he" <jian(dot)universality(at)gmail(dot)com> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: [BUG FIX] Fix validation of COPY options FORCE_NOT_NULL/FORCE_NULL |
Date: | 2024-10-24 06:41:03 |
Message-ID: | 3bfe8c2c-047a-4cd8-b94b-717396829d8f@app.fastmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Oct 19, 2024, at 09:52, Joel Jacobson wrote:
> However, since my last email, I've found some other problems in this area,
> and think we should do a more ambitious improvement, by rearranging the
> incorrect options tests into three categories:
>
> 1. incorrect COPY {FROM|TO} options
> 2. incorrect COPY FROM options
> 3. incorrect COPY TO options
>
> Also, I've found two new problems:
>
> 1. Incorrect options tests are missing for the QUOTE and ESCPAE options.
> This was discovered by Jian He in a different thread.
>
> 2. One of the ON_ERROR incorrect options tests also depend on the order
> of checks in ProcessCopyOptions.
>
> To explain my current focus on the COPY tests, it's because we're currently
> working on the new raw format for COPY, and it would be nice to cleanup these
> tests as a preparatory step first.
I realize these suggested changes are out of scope for $subject, that was about a bug fix.
Therefore closing this patch and marking it as Committed.
/Joel
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2024-10-24 06:41:15 | Re: Refactor to use common function 'get_publications_str'. |
Previous Message | Amit Langote | 2024-10-24 06:33:13 | Re: Wrong result when enable_partitionwise_join is on if collation of PartitionKey and Column is different. |