| From: | Andrei Lepikhov <lepihov(at)gmail(dot)com> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Cc: | Artur Zakirov <zaartur(at)gmail(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, Aleksander Alekseev <aleksander(at)timescale(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: type cache cleanup improvements |
| Date: | 2024-10-21 05:36:04 |
| Message-ID: | 3b6d9bcf-5b48-4210-921b-4641c74e1b39@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 21/10/2024 00:36, Alexander Korotkov wrote:
> On Thu, Oct 17, 2024 at 12:41 PM Andrei Lepikhov <lepihov(at)gmail(dot)com> wrote:
>> I think the first patch may already be committed, and this little burden
>> may be avoided in future versions.
> I've integrated your patch. But I think
> finalize_in_progress_typentries() is more appropriate place to check
> typentry for NULL. Also, I've revised the
> finalize_in_progress_typentries() header comment. I'm going to push
> these patches if no objections.
I agree with your idea. Also, I think it would be more conventional not
to check the type entry for a NULL value but to test the 'found' value
instead.
And thanks for the injection points tests! I must have slipped my mind
about this option.
Now, the patch set looks good for me.
--
regards, Andrei Lepikhov
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrei Lepikhov | 2024-10-21 05:40:14 | Re: type cache cleanup improvements |
| Previous Message | vignesh C | 2024-10-21 05:21:13 | Re: Pgoutput not capturing the generated columns |