From: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
---|---|
To: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: using extended statistics to improve join estimates |
Date: | 2021-10-06 22:05:39 |
Message-ID: | 3aa13399-8dac-e13a-5ce9-d528ab93efb8@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 10/6/21 23:03, Zhihong Yu wrote:
> Hi,
>
> + conditions2 = statext_determine_join_restrictions(root, rel, mcv);
> +
> + /* if the new statistics covers more conditions, use it */
> + if (list_length(conditions2) > list_length(conditions1))
> + {
> + mcv = stat;
>
> It seems conditions2 is calculated using mcv, I wonder why mcv is
> replaced by stat (for conditions1 whose length is shorter) ?
>
Yeah, that's wrong - it should be the other way around, i.e.
if (list_length(conditions1) > list_length(conditions2))
There's no test with multiple candidate statistics yet, so this went
unnoticed :-/
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2021-10-06 22:20:14 | Re: BUG #17212: pg_amcheck fails on checking temporary relations |
Previous Message | Mark Dilger | 2021-10-06 22:03:08 | Re: BUG #17212: pg_amcheck fails on checking temporary relations |